Add the possibility to add more settings and update the lsync conf.d feature #16
Conversation
STATE: Currently, the default template fits only the scientific dsitribution (version 2.1) and everything else is treated as exception. FIX: Set scientific distribution as the exception and everyhting else as the default configuration. Change-Id: I407d5182487629e6fbe941786ca68ce1fd60870e
STATE: Currently, the lsyncd general options are set statically. FIX: Add the possibility to define any settings into a hash and populate 'lsyncd.conf' with it. Change-Id: If8617a422bcfca22786c7d76bb8368db1c88775d
STATE: Currently, the lua code supposed to include file into 'lsyncd.conf' does not work properly (Ref: lsyncd/lsyncd#441) FIX: Use the code suggested into the PR Change-Id: I50be7b2c4dc4e55751b63da61992895f5e0ca505
Lsyncd default template and support for more parameters
|
Why are the distro specific templates being removed? Those are meant to support the versions of lsyncd available on those platforms. If a distro is distributing a newer version of lsyncd with a different configuration format, then a new template should be created for that distro version. Also, please update the tests and ensure they pass. |
|
Hello @dgivens, The way I understood it is as follow:
So We tried to easy the process of updating the most common templates, so we created the exception for the scientific distribution only, does that sound fair for you? Regards, |
|
When I originally created this cookbook, I was running Debian Wheezy, which was still on 2.0. Since Wheezy is going to be EOL in May, I don't see a reason for this cookbook to continue to support it. I believe Scientific Linux 6+ is also on lsyncd 2.1.x, so you can rip that out as well. Please ensure the chefspec and serverspec tests are updated and test-kitchen passes for the major current platforms: Once the tests are all good, I'll merge the PR. |
No description provided.