Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix class extension #57

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Matrix class extension #57

wants to merge 16 commits into from

Conversation

dsambit
Copy link
Member

@dsambit dsambit commented Aug 18, 2022

No description provided.

}

// FIXME: to be implemented (not complex conjugate transpose)
// S.complexConjugate();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iancclin Please note the FIXME comments

* @warning There is no boundary check in this function. The user should
* be responsible that the size of data array should have
* (j2-j1)*(i2-i1) size.
* @param i1 the global index of the first row of the submatrix.
Copy link
Member Author

@dsambit dsambit Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iancclin Could you please clarify in the documentation whether the global index is counted starting from 0 or 1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants