Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add an e2e test for canister_info. #4074

Merged
merged 2 commits into from
Jan 22, 2025
Merged

chore: add an e2e test for canister_info. #4074

merged 2 commits into from
Jan 22, 2025

Conversation

vincent-dfinity
Copy link
Contributor

@vincent-dfinity vincent-dfinity commented Jan 22, 2025 •
edited
Loading

Description

Add an e2e test for canister_info.

How Has This Been Tested?

Added a test only.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@vincent-dfinity vincent-dfinity requested a review from a team as a code owner January 22, 2025 09:59
@vincent-dfinity vincent-dfinity enabled auto-merge (squash) January 22, 2025 10:25
mraszyk
mraszyk approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this regression test!

@vincent-dfinity vincent-dfinity merged commit 29f2254 into master Jan 22, 2025
294 checks passed
@vincent-dfinity vincent-dfinity deleted the vincent/canister_info branch January 22, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

@mraszyk mraszyk mraszyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincent-dfinity @mraszyk @ericswanson-dfinity