Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove remaining pocketic test exclusions #4061

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

adamspofford-dfinity
Copy link
Contributor

Tests specifically about the behavior of the bitcoin and outcalls HTTP adapter remain replica-only since those are implementation details. create.bash#4 remains replica-only since it relies on subnets not existing and canister IDs being freeform. Everything else now works with PocketIC after adding a fiduciary subnet.

@adamspofford-dfinity adamspofford-dfinity marked this pull request as ready for review January 10, 2025 23:52
@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner January 10, 2025 23:52
@adamspofford-dfinity adamspofford-dfinity enabled auto-merge (squash) January 11, 2025 00:36
@adamspofford-dfinity adamspofford-dfinity merged commit c2a8857 into master Jan 11, 2025
298 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/pocketic-tests branch January 11, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants