test: add e2e test for canister request-status with different identity #4047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
reviewed
Dec 19, 2024
|
|
||
| @test "request-status requires same identity" { | ||
| install_asset greet | ||
| dfx_start --artificial-delay 10000 |
There was a problem hiding this comment.
Why such an artificial delay?
There was a problem hiding this comment.
Later in this test, we try to make a call asynchronously and get the request-id (in stdout):
dfx canister call --async hello_backend greet Bob
Then we request-status of the request
dfx canister request-status --output raw "$stdout" "$(dfx canister id hello_backend)"
In my PR #3920, I bumped the agent-rs dependency to v0.38 which contains this change: dfinity/agent-rs#595
Without the --artificial-delay 10000, the first step won't output the request-id, instead it will output the call result ("Hello, Bob!") directly.
Adding --artificial-delay 10000 to dfx start served as a workaround to preserve the existing test behavior.
mraszyk
approved these changes
Dec 19, 2024
lwshang
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a test for
dfx canister request-status, but not one that shows the identity must match the one used withdfx canister call.