Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: installer downloads and executes dfxvm #3465

Conversation

ericswanson-dfinity
Copy link
Member

Description

Alters the install script to install dfxvm, rather than dfx.

Note the base branch for the PR is not master. A PR from the base branch will be submitted once we are ready to release dfxvm.

The script is a lot simpler, in part because it always downloads the latest version. Even so, I restructured it a bit:

  • make sure the temporary directory is always cleaned up
  • handle errors in subshells properly
  • never try to download an aarch64-unknown-linux-gnu build, which wouldn't exist

Also updates the downloader to pass --progress-bar to curl, which is much more streamlined. The --progress-bar parameter was added in curl 5.10 in 1999.

Fixes https://dfinity.atlassian.net/browse/SDK-1278

How Has This Been Tested?

bash ./install.sh , with or without DFX_VERSION, run from the public/ directory.

Checklist:

@ericswanson-dfinity ericswanson-dfinity merged commit 25449c2 into sdk-1278-dfxvm-install-script Dec 5, 2023
164 checks passed
@ericswanson-dfinity ericswanson-dfinity deleted the ens/sdk-1278-install-dfxvm branch December 5, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants