fix: remind to build before install #3446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SDK-971
When installing a canister, if the canister is not built yet, a more informative message will be shown:
The original request was to allow directly installing custom canisters which specify wasm path. However, for such custom canisters,
dfx
may do some necessary post-processing as a part ofdfx build
and install the processed wasm later. Directly installing the exact wasm specified indfx.json
will be an inconsistent behavior.Also, from the source code perspective. The canister type specific information including whether the
wasm
field is specified are not available to theinstall_canister
function. We'll have to expose too much specific information at this level to allow a special rule here.Therefore, I improve the
install_canister
function by giving better error message in such case.Before this change, users may got confused that
dfx
reports "Fail to read the wasm file" even though they specified it indfx.json
. The new error message is more helpful that it provides the command to fix the issue.How Has This Been Tested?
e2e
Checklist: