Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: frontend code crashing when there is no canister ID #3403

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

vporton
Copy link
Contributor

@vporton vporton commented Sep 29, 2023

Fix a bug with nonexistent canister.

Description

When there is no canister ID (e.g. an actor class for creating multiple canisters), frontend code was crashing on input like

import { idlFactory as CanDBPartitionIDL } from "../../../declarations/CanDBPartition";

How Has This Been Tested?

I tested on a real still closed-source software.

It compiled and worked.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@vporton vporton requested review from chenyan-dfinity and a team as code owners September 29, 2023 19:53
@ghost ghost added the cla:agreed label Sep 29, 2023
@vporton
Copy link
Contributor Author

vporton commented Dec 10, 2023

@chenyan-dfinity I am asking you to speed up accepting this pull request, because without it I have a trouble with work on my dapp.

@chenyan-dfinity chenyan-dfinity enabled auto-merge (squash) December 10, 2023 22:02
@chenyan-dfinity chenyan-dfinity merged commit a2a2255 into dfinity:master Dec 10, 2023
171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants