Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: migration expressions #4845

Open
wants to merge 15 commits into
base: claudio/migration
Choose a base branch
from
Open

doc: migration expressions #4845

wants to merge 15 commits into from

Conversation

crusso
Copy link
Contributor

@crusso crusso commented Jan 14, 2025 •
edited
Loading

Builds on #4812.

Document migration expressions.

  • Extract examples to checkable files.
  • Review

The best way to review this is to do make preview in motoko\doc\ so you can see the inlined examples...

@crusso crusso changed the base branch from master to claudio/migration January 14, 2025 11:17
@crusso crusso mentioned this pull request Jan 14, 2025
Open
15 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

Comparing from f3994a4 to ebee463:
The produced WebAssembly code seems to be completely unchanged.

@crusso crusso marked this pull request as ready for review January 20, 2025 17:05
ggreif
ggreif reviewed Jan 21, 2025
View reviewed changes
doc/md/examples/Card-v1a.mo
var map : [(Nat32, OldCard)] = [];
var newMap : [(Nat32, NewCard)] = Array.map<(Nat32, OldCard), (Nat32, NewCard)>(
map,
func(key, { title }) { (key, { title; description = "<empty>" }) },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func(key, { title }) { (key, { title; description = "<empty>" }) },
func(key, { title }) = (key, { title; description = "<empty>" }),

@crusso crusso requested a review from a team as a code owner February 1, 2025 14:25
@crusso crusso mentioned this pull request Feb 1, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif left review comments

@luc-blaeser luc-blaeser Awaiting requested review from luc-blaeser

@rvanasa rvanasa Awaiting requested review from rvanasa

@jessiemongeon1 jessiemongeon1 Awaiting requested review from jessiemongeon1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crusso @ggreif