Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IDX): define RUN_ON_DIFF_ONLY on the workflow level #2266

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix(IDX): define RUN_ON_DIFF_ONLY on the workflow level #2266

merged 2 commits into from
Oct 25, 2024
+2 −4

Conversation

basvandijk
Copy link
Collaborator

@basvandijk basvandijk commented Oct 25, 2024 •
edited
Loading

This fixes a bug introduced in #2245. It defines the RUN_ON_DIFF_ONLY env var on the workflow level such that the Set BAZEL_EXTRA_ARGS step has access to it.

@github-actions github-actions bot added the fix label Oct 25, 2024
@basvandijk basvandijk marked this pull request as ready for review October 25, 2024 16:09
@basvandijk basvandijk requested a review from a team as a code owner October 25, 2024 16:09
@github-actions github-actions bot added the @idx label Oct 25, 2024
@basvandijk basvandijk added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit 3fa045f Oct 25, 2024
32 checks passed
@basvandijk basvandijk deleted the basvandijk/fix-ci-main-missing-RUN_ON_DIFF_ONLY branch October 25, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanusFischer StephanusFischer StephanusFischer approved these changes

Assignees
No one assigned
Labels
fix @idx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basvandijk @StephanusFischer