fix(ckbtc): improve error handling in new KYT canister #2263
+125
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THLO
reviewed
Oct 25, 2024
rs/bitcoin/kyt/src/fetch.rs
Outdated
| state::set_fetched_address(txid, index, address.clone()); | ||
| } else { | ||
| // This error shouldn't happen unless blockdata is corrupted. | ||
| return CheckTransactionRetriable::TransientInternalError(format!( |
There was a problem hiding this comment.
Why is this considered a transient error?
There was a problem hiding this comment.
After a second thought, I think you are right. This should be an irrecoverable error for 2 reasons:
- The next call to
check_transactionwill return the same error, because the dependency transaction is already fetched into cache, and will not be retried. - The transaction data already passed txid check, so most likely all RPC providers would return the same data, and the error will not go away by trying with another provider.
WDYT?
There was a problem hiding this comment.
The transaction data already passed txid check,
To me this seems like the key argument why this error should indeed be irrecoverable.
gregorydemay
approved these changes
Oct 25, 2024
| // inputs of other transactions, so it is okay to treat them as `None`. | ||
| outputs.push( | ||
| Address::from_script(&output.script_pubkey, bitcoin::Network::from(*btc_network)) | ||
| .ok(), |
There was a problem hiding this comment.
nit: should we maybe log the errors?
ninegua
added
the
CI_OVERRIDE_DIDC_CHECK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some valid bitcoin transactions may have output scripts that do not translate to any valid addresses. They are also not the inputs of other transactions.
The correct handling is to ignore such outputs when computing output addresses, and set them to
Noneinstead. This avoids throwing an error when we shouldn't be.Also add a new test case to ensure correct handling if we do encounter an real error, i.e. when such output becomes the input of a transaction, which certainly would indicate corrupted block data, and in theory should never happen.