implement hoppers #884
implement hoppers #884
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
should be good for review, fully working now |
| // Hopper is a model used by hoppers. | ||
| type Hopper struct{} | ||
|
|
||
| // BBox returns a physics.BBox that spans a full block. |
There was a problem hiding this comment.
The hopper model is not a full block. There is a small hole at the top.
There was a problem hiding this comment.
I can't seem to find the model bbox, would you have it?
There was a problem hiding this comment.
| w := e.World() | ||
| pos := cube.PosFromVec3(e.Position()) | ||
| blockPos := pos.Side(cube.FaceDown) | ||
|
|
||
| bl, ok := w.Block(blockPos).(block.Hopper) | ||
| if ok && !bl.Powered && bl.CollectCooldown <= 0 { | ||
| _, err := bl.Inventory().AddItem(i.i) | ||
| if err != nil { | ||
| // We couldn't add any of the item to the inventory, so we ignore it. | ||
| return i.passive.Tick(e) | ||
| } | ||
|
|
||
| _ = e.Close() | ||
| bl.CollectCooldown = 4 | ||
| w.SetBlock(blockPos, bl, nil) | ||
| } |
There was a problem hiding this comment.
It would be good if this could be moved to the actual Hopper.
There was a problem hiding this comment.
it is not possible due to import cycles
|
|
||
| // Facing is the direction the hopper is facing. | ||
| Facing cube.Face | ||
| // Powered is whether the hopper is powered or not. |
There was a problem hiding this comment.
Add specifics on what powered vs. not powered means for the hopper
| h.CollectCooldown-- | ||
| h.LastTick = currentTick | ||
|
|
||
| if h.TransferCooldown > 0 || h.CollectCooldown >= 0 { |
There was a problem hiding this comment.
Why are the operators different between these two conditions? Shouldn't the second condition be h.CollectCooldown > 0?
There was a problem hiding this comment.
And should transfer cooldown be blocking collecting, and vice versa?
|
|
||
| // HopperInsertable represents a block that can have its contents inserted into by a hopper. | ||
| type HopperInsertable interface { | ||
| Container |
There was a problem hiding this comment.
The block does not necessarily have to implement the Container interface, e.g. jukeboxes and composters
There was a problem hiding this comment.
Also please implement behavior for those two blocks 😅
| Container | ||
|
|
||
| // InsertItem attempts to insert a single item into the container. If the insertion was successful, the item is | ||
| // returned. If the insertion was unsuccessful, the item stack returned will be empty. InsertItem by itself does |
There was a problem hiding this comment.
This comment seems to be outdated, there is no item stack involved in the return type.
|
|
||
| // insertItem inserts an item into a container from the hopper. | ||
| func (h Hopper) insertItem(pos cube.Pos, w *world.World) bool { | ||
| dest, ok := w.Block(pos.Side(h.Facing)).(Container) |
There was a problem hiding this comment.
This insert item logic works under the assumption that there is an inventory associated with the block, which is a big no, see comment above.
This will need some refactoring so I haven't reviewed this in detail yet.
|
|
||
| // HopperExtractable represents a block that can have its contents extracted by a hopper. | ||
| type HopperExtractable interface { | ||
| Container |
There was a problem hiding this comment.
Same problem with HopperInsertable, have not reviewed in detail.
Co-authored-by: DaPigGuy <[email protected]>
Co-authored-by: DaPigGuy <[email protected]>
|
this was completed in #911 this pr can be closed |
No description provided.