Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DWS-4550 env varible host path #37

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

maratkanov-a
Copy link
Contributor

@maratkanov-a maratkanov-a commented Dec 25, 2024

JIRA Issue link

https://dws-corp.atlassian.net/browse/DWS-4550

Describe your changes

ability to work with dynamic terraform api

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

Copy link

Current total test coverage: 85.4%
Quality gate passed ✅

Copy link
Contributor

@berelton berelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how it will affect production usage?

Example:
https://docs.nodeshift.com/terraform/overview

@maratkanov-a
Copy link
Contributor Author

no difference for production usage

@berelton berelton changed the title Dws 4550 env varible host path feat: DWS-4550 env varible host path Dec 27, 2024
@maratkanov-a maratkanov-a force-pushed the dws-4550-env-varible-host-path branch from a5c8299 to ab54178 Compare December 27, 2024 11:03
@maratkanov-a maratkanov-a added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 659b13b Dec 27, 2024
3 checks passed
@maratkanov-a maratkanov-a deleted the dws-4550-env-varible-host-path branch December 27, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants