Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Generic Delete confirmation Modal #528

Merged
merged 45 commits into from
Feb 4, 2025
Merged

feat: Generic Delete confirmation Modal #528

merged 45 commits into from
Feb 4, 2025

Conversation

shivani170
Copy link
Contributor

Description

Generic Delete confirmation Modal

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

RohitRaj011
RohitRaj011 previously approved these changes Jan 23, 2025
View reviewed changes
RohitRaj011
RohitRaj011 previously approved these changes Jan 24, 2025
View reviewed changes
@shivani170 shivani170 changed the title feat Generic Delete confirmation Modal feat: Generic Delete confirmation Modal Jan 24, 2025
shivani170 and others added 16 commits January 28, 2025 12:29
@shivani170
chore: version bump
ccd104e
@shivani170
chore: version bump
ed7d503
@shivani170
Merge branch 'develop' into feat/delete-confirmation
66ba182
@shivani170
chore: version bump
eca4039
@shivani170
chore: doc added for delete modal props
0b65e41
@shivani170
chore: version bump with removal of url & reload
382ac85
@shivani170
chore: version bump
3c460ca
@shivani170
Merge branch 'develop' into feat/delete-confirmation
9511f08
@shivani170
chore: delete component removed
953ddae
@shivani170
chore: delete subtitle default value fixed
c1b6566
@shivani170
Merge branch 'feat/delete-confirmation' into feat/delete-confirmation-v3
3c84f4d
@shivani170
chore: finally removed from component
19e775c
@shivani170
Merge branch 'develop' into feat/delete-confirmation
35479a0
@shivani170
Merge pull request #550 from devtron-labs/feat/delete-confirmation-v3
7c5a8da 
feat: delete confirmation v3
@shivani170
chore: code refactoring
2aa3684
@shivani170
chore: stop propagation mandate for all delete events
ac1a400
vivek-devtron
vivek-devtron previously approved these changes Feb 3, 2025
View reviewed changes
vivek-devtron
vivek-devtron previously approved these changes Feb 4, 2025
View reviewed changes
@shivani170 shivani170 merged commit 51234ed into develop Feb 4, 2025
4 checks passed
@shivani170 shivani170 deleted the feat/delete-confirmation branch February 4, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivek-devtron vivek-devtron vivek-devtron approved these changes

@RohitRaj011 RohitRaj011 RohitRaj011 approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivani170 @RohitRaj011 @vivek-devtron