Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Notification test case id #2347

Merged
merged 1 commit into from
Jan 9, 2025
Merged

chore: Notification test case id #2347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/notifications/ConfigurationDrawerModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const ConfigurationTabDrawerModal = ({
const renderFooter = () => (
<div className="px-20 py-16 flex right dc__gap-12 dc__zi-1 dc__border-top bcn-0">
<Button
dataTestId="ses-config-modal-close-button"
dataTestId={`${modal}-config-modal-close-button`}
size={ComponentSizeType.large}
onClick={closeModal}
text="Cancel"
Expand All @@ -31,7 +31,7 @@ export const ConfigurationTabDrawerModal = ({
style={ButtonStyleType.neutral}
/>
<Button
dataTestId="add-ses-save-button"
dataTestId={`add-${modal}-save-button`}
size={ComponentSizeType.large}
onClick={saveConfigModal}
text="Save"
Expand Down
4 changes: 2 additions & 2 deletions src/components/notifications/ConfigurationTabsSwitcher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const ConfigurationTabSwitcher = () => {
{getConfigurationTabTextWithIcon().map((tab, index) => (
<button
type="button"
data-testid={`tab-${tab.link}`}
data-testid={`${tab.link}-tab-title`}
className={`tab-group__tab dc__unset-button-styles flexbox dc__gap-1 dc__hover-text-n90 dc__gap-6 px-10 py-4 fw-6 ${index === 0 ? 'dc__left-radius-4 ' : ''}
${index === getConfigurationTabTextWithIcon().length - 1 ? 'dc__right-radius-4' : ''} ${activeTab === tab.link ? 'bcn-1 fw-6 cn-9' : 'bcn-0'} cn-7`}
key={tab.link}
Expand All @@ -51,7 +51,7 @@ export const ConfigurationTabSwitcher = () => {
onClick={handleAddClick}
variant={ButtonVariantType.primary}
size={ComponentSizeType.small}
dataTestId="add-configuration"
dataTestId={`${activeTab}-add-button`}
startIcon={<Add />}
text={`Add ${getTabText(activeTab)}`}
/>
Expand Down
2 changes: 1 addition & 1 deletion src/components/notifications/SESConfigModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ const SESConfigModal = ({
value={form.configName}
onChange={handleInputChange}
onBlur={handleBlur}
placeholder="Configuration name"
placeholder="Enter a name"
autoFocus
isRequiredField
error={isFormValid[ConfigurationFieldKeys.CONFIG_NAME].message}
Expand Down
4 changes: 2 additions & 2 deletions src/components/notifications/SlackConfigModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export const SlackConfigModal: React.FC<SlackConfigModalProps> = ({
value={form.configName}
onChange={handleInputChange}
onBlur={handleBlur}
placeholder="Channel name"
placeholder="Enter channel name"
autoFocus
isRequiredField
error={isFormValid[ConfigurationFieldKeys.CONFIG_NAME].message}
Expand All @@ -214,7 +214,7 @@ export const SlackConfigModal: React.FC<SlackConfigModalProps> = ({
label={renderWebhookUrlLabel()}
name={ConfigurationFieldKeys.WEBHOOK_URL}
value={form.webhookUrl}
placeholder="Enter Incoming Webhook URL"
placeholder="Enter incoming webhook URL"
onChange={handleInputChange}
onBlur={handleBlur}
isRequiredField
Expand Down
4 changes: 2 additions & 2 deletions src/components/notifications/WebhookConfigModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export const WebhookConfigModal = ({
label="Configuration name"
value={form.configName}
onChange={handleInputChange}
placeholder="Enter name"
placeholder="Enter a name"
error={isFormValid[ConfigurationFieldKeys.CONFIG_NAME].message}
name={ConfigurationFieldKeys.CONFIG_NAME}
dataTestid="webhook-modal__name"
Expand All @@ -223,7 +223,7 @@ export const WebhookConfigModal = ({
label="Webhook URL"
value={form.webhookUrl}
onChange={handleInputChange}
placeholder="Enter Incoming Webhook URL"
placeholder="Enter incoming webhook URL"
error={isFormValid[ConfigurationFieldKeys.WEBHOOK_URL].message}
name={ConfigurationFieldKeys.WEBHOOK_URL}
dataTestid="webhook-modal__url"
Expand Down
Loading