-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: restructure into a monorepo using pnpm #2140
base: develop
Are you sure you want to change the base?
Conversation
f370b6f
to
f29ec8d
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
|
"worker-loader": "3.0.8" | ||
"lint": "pnpm run -r lint", | ||
"build:prod": "pnpm run -r build", | ||
"build:libs": "pnpm filter './packages/**' build" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's start a pnpm start script as well
"build:libs": "pnpm filter './packages/**' build" | |
"build:libs": "pnpm --filter './packages/**' build" |
} | ||
} | ||
"devDependencies": { | ||
"husky": "^7.0.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add lint-staged as well
RUN if [ -d "./devtron-fe-lib" ]; then rm -rf packages/devtron-fe-lib; cp -r ./devtron-fe-lib packages/devtron-fe-lib; fi | ||
|
||
RUN pnpm i | ||
RUN pnpm run build:prod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's verify that no source maps are built for fe-lib
RUN yarn build-storybook | ||
RUN pnpm i | ||
|
||
RUN pnpm --filter=web build-storybook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- move to package.json
- also add the script for start storybook
ENV PATH="$PNPM_HOME:$PATH" | ||
RUN corepack enable | ||
|
||
WORKDIR /app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename the file back to Dockerfile
@@ -0,0 +1,69 @@ | |||
.eslintrc.cjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Move eslint to the top level along with these files
- What about linting for fe-lib
@@ -0,0 +1,62 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- clean up tsconfig
- add the tsconfig at the root by extending the one from dashboard
- Check for alias at the root level
@@ -0,0 +1,114 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skipping rest of the common-lib.
We can checkout: https://medium.com/@chris_72272/keeping-git-history-when-converting-multiple-repos-into-a-monorepo-97641744d928 or some similar stuff
proxy: { | ||
'/orchestrator': { | ||
target: TARGET_URL, | ||
changeOrigin: true, | ||
}, | ||
'/grafana': TARGET_URL, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create a common object and reuse
}, | ||
"author": "Devtron", | ||
"license": "ISC", | ||
"bugs": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- clean up the package json.
- Check for singleton for react and other stuff. Can those be commoned out?
@@ -29,7 +29,7 @@ import { VitePWA } from 'vite-plugin-pwa' | |||
import tsconfigPaths from 'vite-tsconfig-paths' | |||
|
|||
const WRONG_CODE = `import { bpfrpt_proptype_WindowScroller } from "../WindowScroller.js";` | |||
const TARGET_URL = 'https://preview.devtron.ai/' | |||
const TARGET_URL = 'https://devtron-ent-7.devtron.info/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
@@ -0,0 +1,201 @@ | |||
import { ButtonHTMLAttributes, PropsWithChildren } from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix parsing error
closeMenuOnSelect = false, | ||
...props | ||
}: SelectPickerProps<OptionValue, IsMulti>) => { | ||
const { inputId, required, isDisabled, controlShouldRenderValue = true, value, options } = props |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HMR is not working as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme needs to be updated
# TODO: delete unnecessary stuff | ||
test-results/ | ||
playwright-report/ | ||
playwright/.cache/ | ||
playwright/.auth/ | ||
.npmrc | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Also add your script
packages/devtron-fe-lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fe-lib PR
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: