chore: restructure into a monorepo using pnpm #2140

Elessar1802 · 2024-10-20T13:20:10Z

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR require documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas

sonarcloud · 2024-10-21T04:44:47Z

Quality Gate failed

Failed conditions
25 Security Hotspots
4.0% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

eshankvaish · 2024-10-24T06:45:43Z

Remove linter.py, sentry.sh
Common out custom.d.ts
vite-env

eshankvaish · 2024-10-24T06:18:59Z

package.json

-        "worker-loader": "3.0.8"
+        "lint": "pnpm run -r lint",
+        "build:prod": "pnpm run -r build",
+        "build:libs": "pnpm filter './packages/**' build"


let's start a pnpm start script as well

Suggested change

"build:libs": "pnpm filter './packages/**' build"

"build:libs": "pnpm --filter './packages/**' build"

eshankvaish · 2024-10-24T06:19:15Z

package.json

-        }
-    }
+	"devDependencies": {
+		"husky": "^7.0.4"


let's add lint-staged as well

eshankvaish · 2024-10-24T06:20:54Z

Dockerfile.web

+RUN if [ -d "./devtron-fe-lib" ]; then rm -rf packages/devtron-fe-lib; cp -r ./devtron-fe-lib packages/devtron-fe-lib; fi
+
+RUN pnpm i
+RUN pnpm run build:prod


let's verify that no source maps are built for fe-lib

eshankvaish · 2024-10-24T06:22:57Z

Dockerfile.storybook

-RUN yarn build-storybook
+RUN pnpm i
+
+RUN pnpm --filter=web build-storybook


move to package.json

also add the script for start storybook

eshankvaish · 2024-10-24T06:23:54Z

Dockerfile.web

+ENV PATH="$PNPM_HOME:$PATH"
+RUN corepack enable
+
+WORKDIR /app


rename the file back to Dockerfile

eshankvaish · 2024-10-24T06:33:40Z

packages/devtron-fe-common-lib/.eslintignore

@@ -0,0 +1,69 @@
+.eslintrc.cjs


Move eslint to the top level along with these files

What about linting for fe-lib

eshankvaish · 2024-10-24T06:35:25Z

packages/devtron-fe-common-lib/tsconfig.json

@@ -0,0 +1,62 @@
+{


clean up tsconfig

add the tsconfig at the root by extending the one from dashboard

Check for alias at the root level

eshankvaish · 2024-10-24T06:36:15Z

packages/devtron-fe-common-lib/package.json

@@ -0,0 +1,114 @@
+{


skipping rest of the common-lib.

We can checkout: https://medium.com/@chris_72272/keeping-git-history-when-converting-multiple-repos-into-a-monorepo-97641744d928 or some similar stuff

eshankvaish · 2024-10-24T06:37:14Z

apps/web/vite.config.mts

+            proxy: {
+                '/orchestrator': {
+                    target: TARGET_URL,
+                    changeOrigin: true,
+                },
+                '/grafana': TARGET_URL,
+            },


create a common object and reuse

eshankvaish · 2024-10-24T06:39:37Z

packages/devtron-fe-common-lib/package.json

+    },
+    "author": "Devtron",
+    "license": "ISC",
+    "bugs": {


clean up the package json.

Check for singleton for react and other stuff. Can those be commoned out?

eshankvaish · 2024-10-24T06:53:19Z

apps/web/vite.config.mts

@@ -29,7 +29,7 @@ import { VitePWA } from 'vite-plugin-pwa'
 import tsconfigPaths from 'vite-tsconfig-paths'

 const WRONG_CODE = `import { bpfrpt_proptype_WindowScroller } from "../WindowScroller.js";`
-const TARGET_URL = 'https://preview.devtron.ai/'
+const TARGET_URL = 'https://devtron-ent-7.devtron.info/'


eshankvaish · 2024-10-24T06:57:37Z

packages/devtron-fe-common-lib/src/Shared/Components/Button/Button.component.tsx

@@ -0,0 +1,201 @@
+import { ButtonHTMLAttributes, PropsWithChildren } from 'react'


fix parsing error

eshankvaish · 2024-10-24T06:59:21Z

packages/devtron-fe-common-lib/src/Shared/Components/SelectPicker/SelectPicker.component.tsx

+    closeMenuOnSelect = false,
+    ...props
+}: SelectPickerProps<OptionValue, IsMulti>) => {
+    const { inputId, required, isDisabled, controlShouldRenderValue = true, value, options } = props


HMR is not working as expected

Readme needs to be updated

eshankvaish · 2024-10-24T07:03:49Z

.gitignore

+# TODO: delete unnecessary stuff
+test-results/
+playwright-report/
+playwright/.cache/
 playwright/.auth/
 .npmrc



Also add your script

Suggested change

packages/devtron-fe-lib

Elessar1802 added 4 commits October 20, 2024 17:17

feat(repo)!: restructure into a monorepo

0f98d80

chore: update Dockerfile(s) & allow build on arm

477ff64

chore: remove --frozen-lockfile option due to fe-lib dep

a377eb1

chore: update Dockerfile.web to override devtron-fe-lib if mounted

f29ec8d

Elessar1802 force-pushed the chore/pnpm branch from f370b6f to f29ec8d Compare October 21, 2024 04:41

eshankvaish requested changes Oct 24, 2024

View reviewed changes

Elessar1802 marked this pull request as ready for review October 24, 2024 07:08

Elessar1802 requested review from vikramdevtron and vivek-devtron as code owners October 24, 2024 07:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: restructure into a monorepo using pnpm #2140

chore: restructure into a monorepo using pnpm #2140

Elessar1802 commented Oct 20, 2024

sonarcloud bot commented Oct 21, 2024

eshankvaish commented Oct 24, 2024

eshankvaish Oct 24, 2024 •

edited

Loading

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

eshankvaish Oct 24, 2024

	"build:libs": "pnpm filter './packages/**' build"
	"build:libs": "pnpm --filter './packages/**' build"

		@@ -0,0 +1,201 @@
		import { ButtonHTMLAttributes, PropsWithChildren } from 'react'

chore: restructure into a monorepo using pnpm #2140

Are you sure you want to change the base?

chore: restructure into a monorepo using pnpm #2140

Conversation

Elessar1802 commented Oct 20, 2024

Description

Type of change

How Has This Been Tested?

Checklist:

sonarcloud bot commented Oct 21, 2024

Quality Gate failed

eshankvaish commented Oct 24, 2024

eshankvaish Oct 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eshankvaish Oct 24, 2024 •

edited

Loading