Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rbac automation #15

Open
wants to merge 16 commits into
base: regression
Choose a base branch
from
Open

Rbac automation #15

wants to merge 16 commits into from

Conversation

Shivam-nagar23
Copy link
Member

No description provided.

@Shivam-nagar23 Shivam-nagar23 self-assigned this Feb 19, 2023
@gitguardian
Copy link

gitguardian bot commented Feb 19, 2023

⚠️ GitGuardian has uncovered 25 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
5438937 Generic High Entropy Secret 313a969 RbacFlows/RbacFlowsForDevtronApps.go View secret
5438938 Generic High Entropy Secret 313a969 RbacFlows/RbacFlowsForDevtronApps.go View secret
5438937 Generic High Entropy Secret e8aac9a RbacFlows/RbacFlowsForDevtronApps.go View secret
5438937 Generic High Entropy Secret e8aac9a RbacFlows/RbacFlowsForDevtronApps.go View secret
5438938 Generic High Entropy Secret e8aac9a RbacFlows/RbacFlowsForDevtronApps.go View secret
5438939 Generic High Entropy Secret e8aac9a RbacFlows/RbacFlowsForDevtronApps.go View secret
5438938 Generic High Entropy Secret e8aac9a RbacFlows/RbacFlowsForDevtronApps.go View secret
5438939 Generic High Entropy Secret e8aac9a RbacFlows/RbacFlowsForDevtronApps.go View secret
3753407 Generic High Entropy Secret e8aac9a testUtils/credentials.json View secret
5810078 GitHub Access Token e8aac9a testUtils/credentials.json View secret
3753407 Generic High Entropy Secret 40c7381 testUtils/credentials.json View secret
5810078 GitHub Access Token 40c7381 testUtils/credentials.json View secret
5438937 Generic High Entropy Secret 3644cc2 RbacFlows/RbacFlowsForDevtronApps.go View secret
5438938 Generic High Entropy Secret 3644cc2 RbacFlows/RbacFlowsForDevtronApps.go View secret
5438938 Generic High Entropy Secret 3644cc2 RbacFlows/RbacFlowsForDevtronApps.go View secret
5438938 Generic High Entropy Secret 3644cc2 RbacFlows/RbacFlowsForDevtronApps.go View secret
5438939 Generic High Entropy Secret 3644cc2 RbacFlows/RbacFlowsForDevtronApps.go View secret
5438938 Generic High Entropy Secret af6af2a RbacFlows/RbacFlowsForDevtronApps.go View secret
5867649 Generic High Entropy Secret af6af2a RbacFlows/RbacFlowsForDevtronApps.go View secret
3447984 Generic High Entropy Secret 8ebee7e ChartRepositoryRouter/CreateChartRepo.go View secret
3447984 Generic High Entropy Secret 8ebee7e ChartRepositoryRouter/DeleteChartRepo.go View secret
3753407 Generic High Entropy Secret 2a47b4b testdata/testUtils/credentials.json View secret
3791673 GitHub Access Token 2a47b4b GitopsConfigRouter/GitopsConfigRouterApiManager.go View secret
5810078 GitHub Access Token 2a47b4b testdata/testUtils/credentials.json View secret
5867649 Generic High Entropy Secret 2a47b4b RbacFlows/RbacFlowsForDevtronApps.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Shivam-nagar23 Shivam-nagar23 changed the base branch from main to regression February 20, 2023 10:20
Shivam-nagar23 and others added 3 commits February 20, 2023 16:02
	modified:   RbacFlows/RbacFlowsForDevtronApps.go
	modified:   RbacFlows/RbacFlowsLogicManager.go
	modified:   testUtils/BasicTestConfProvider.go
"Automation changes for Devtron App"
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
8.4% 8.4% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants