Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Ubuntu Vagrantfile #560

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Created Ubuntu Vagrantfile #560

wants to merge 1 commit into from

Conversation

levlaz
Copy link

@levlaz levlaz commented May 21, 2015

I find that developing on a "clean" VM has several benefits. I am really impressed with cherrymusic and would like to start contributing some code to it.

My first contribution is this vagrantfile that will basically create a fresh Ubuntu 14.04 LTS VM in Virtualbox, and allow you to hack on the code locally while seeing changes in real time on the VM in a web browser.

I find that working with Vagrant makes like a lot easier and I hope that other people will find this useful as well.

Thanks for all of your work on this awesome project!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.57% when pulling 10effd5 on levlaz:devel into 3e22d08 on devsnd:devel.

@6arms1leg
Copy link
Collaborator

Hello @levlaz,

thanks a lot for your contribution! It's much appreciated.
However, so far we tried to keep CherryMusic separate from OS/distribution/platform specific files and I still think that's the way to go.
There are a few other scripts and add-ons (like the AUR build files, the Debian init script and a Firefox add-on), that didn't get merged into the CherryMusic repository. Merging them all into CherryMusic and maintaining them would increase our workload and we can't even keep up with the issues we have now.
Maybe we should start collecting them in a different repository or at least add a section to our wiki that keeps track of all the OS/distribution/platform specific files and redirects to their origin, though. If we agree on the latter, I will take care of the new wiki section.
@levlaz, would it be OK for you to create a GitHub repository for your Vagrant file?
But first let's wait and see what @devsnd and @tilboerner have to say...

@6arms1leg
Copy link
Collaborator

Oh, I just remember we already have a wiki section for 3rd party extensions – it's just not up to date... I will take care of it.

@levlaz
Copy link
Author

levlaz commented May 21, 2015

Hello @6arms1leg thanks so much for the feedback. Keeping the repo as clean as possible definitely makes sense.

Two things,

  1. The choice of Ubuntu for the vagrant file is arbitrary you can deploy any OS including Windows(and I would be happy to add additional ones)
  2. Vagrant is really geared specifically for development so that we can all work from the same playbook. Users should not be deploying CherryMusic with vagrant, but it makes working on different platforms easier for everyone.

I think this is super useful, but its just a suggestion. :) I would be happy to put this somewhere else, please let me know.

Best,
Lev

@devsnd
Copy link
Owner

devsnd commented May 29, 2015

Hi Lev!

Sorry it takes me so long to respond to things happening here, I'll try to get better...

Thanks for taking the time to create a vagrantfile for cherrymusic, but as @6arms1leg already said, I don't think we should mix up deployment and source code in the same repo. I have created another repo that should become the new central place for those kinds of configurations, so that we can link to it from the wiki.

So please just do a pull request and add the vagrantfile into the linux/vagrant folder in the repository.

Users should not be deploying CherryMusic with vagrant, but it makes working on different platforms easier for everyone.

Why so? I'm thinking that having a vagrant or docker images ready would be quite nice. We could even bundle CM with nginx and so on.

Thanks for your contribution! 🍭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants