-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Ensure sponsors are alphabetical (at the same tier) #14469
Conversation
✅ Deploy Preview for devopsdays-web ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
- I got bored of manually fixing the 2024 London sponsors data when I noticed it was non-alphabetical. - So here's a CI check that runs whenever someone edits an event YAML file. - It checks that the sponsors are sorted alphabetically by ID at each tier. Example (events/2024/test/main.yml): ```yaml sponsors: - id: Elephant level: platinum - id: Aardvark level: gold - id: Zebra level: gold - id: Fish level: gold - id: Cat level: silver - id: Dog level: silver ``` would output: ```text Gold sponsors in events/2024/test/main.yml are not sorted alphabetically by ID. ``` and so the user would change the "gold" sponsors ordering to the following, to fix the error: ```yaml - id: Aardvark level: gold - id: Fish level: gold - id: Zebra level: gold ``` I considered fixing the ordering in-place and pushing a commit to the user's PR, but fork PRs don't have a lot of permissions and I'm too tired to think about it seriously on top of organizing an actual conference, so that can maybe be a stretch goal for later.
88accea
to
cd01884
Compare
While this may be esthecailly correct and good for us as humans, but I do not see the need for us to enfore this. HugoIO will sort by weight, alphabetically or a ordered, we do not need to that |
I agree… I don’t think that the code should enforce the order of the sponsors, for example, for Chicago, we tend to put them in the order that they paid/signed up as sponsors, and I don’t think that I would want the code to override the order that I wanted |
Thanks for the feedback, both!
Yep, which is why I feel that the order should be alphabetical in the YAML file so that it appears so on the website. My overall thinking for alphabetical was that it "flows" nicely within the tiers, and also that every sponsor within a tier is (theoretically) equal because they paid the same money so alphabetical enforces that in a way.
I see. I didn't realise that the differences were per-event, I guess I thought people just added new sponsors to the end of the list because it was easier. Lucky you to not be perturbed by the logos being out of order like I am. ;-) But really it doesn't matter, it's just a small nit and each event should retain autonomy, as you say, so I'll close this. Thanks again! |
Example (events/2024/test/main.yml):
would output:
and so the user would change the "gold" sponsors ordering to the following, to fix the error:
I considered fixing the ordering in-place and pushing a commit to the user's PR, but fork PRs don't have a lot of permissions and I'm too tired to think about it seriously on top of organizing an actual conference, so that can maybe be a stretch goal for later.