Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#982: Add plugin recommendation feature to vscode #993

Merged
merged 30 commits into from
Mar 2, 2023
Merged

#982: Add plugin recommendation feature to vscode #993

merged 30 commits into from
Mar 2, 2023

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Nov 24, 2022 •
edited
Loading

This feature adds deactivated plugins as "recommended" plugins for vscode, after vscode is installed. See here.

Link to related issue: #982

@alfeilex alfeilex linked an issue Nov 24, 2022 that may be closed by this pull request
Add new feature to vscode - recommended plugin installation #982
Closed
3 tasks
@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD) labels Nov 24, 2022
@alfeilex
Copy link
Member Author

Please check the comments and my train of thought in the related issue: #982

@alfeilex alfeilex marked this pull request as ready for review November 24, 2022 13:13
hohwille
hohwille requested changes Jan 17, 2023
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for your idea with the recommendation feature and creating this PR. 👍
While I like the idea very much, I do not yet agree that this PR's implementation is ready for merge. Can you have a look? Feel free to get in touch so we can discuss how to address this finally.

scripts/src/main/resources/scripts/command/vscode Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/vscode Outdated Show resolved Hide resolved
CHANGELOG.asciidoc Outdated Show resolved Hide resolved
@alfeilex alfeilex changed the title #982: Add recommendation feature and clean setup option to vscode #982: Add plugin recommendation feature to vscode Jan 18, 2023
hohwille
hohwille approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for your rework and completing this nice feature 👍
Ready for merge now.

@hohwille hohwille added this to the release:2023.02.001 milestone Mar 2, 2023
@hohwille hohwille merged commit f7633e0 into devonfw:master Mar 2, 2023
@alfeilex alfeilex deleted the feature/vscode-recommendations branch March 7, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees
No one assigned
Labels
bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)
Projects
None yet
Milestone
release:2023.02.001
Development

Successfully merging this pull request may close these issues.

Add new feature to vscode - recommended plugin installation
2 participants
@alfeilex @hohwille