-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: kubeflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2117
Conversation
…k, line, line-wordmark)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you for the contribution! 😄
The json looks excellent, but the SVGs need a few modifications.
The viewboxes for all SVGs are not 0 0 128 128
and the plain-wordmark svg has strokes that should be converted into a unified path.
sorry @canaleal, looks like i committed the unfinished files. should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work.
I left a few comments about the padding/alignment on some of the SVGs, but aside from that everything else looks excellent.
@canaleal i fixed the image box issues. hope this time i got it right 🤞 |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Double check these details before you open a PR
develop
branch.devicon.json
file as seen here**This PR closes #2086 **
Link to prove your SVG is correct and up-to-date.