Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: googlecolab (original, plain) #2055

Merged
merged 4 commits into from
Aug 26, 2024
Merged

new icon: googlecolab (original, plain) #2055

merged 4 commits into from
Aug 26, 2024

Conversation

dariakiseleva
Copy link

@dariakiseleva dariakiseleva commented Nov 25, 2023 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #2228

Link to prove your SVG is correct and up-to-date.

https://colab.research.google.com/

@canaleal canaleal changed the title new icon: Google Colab (original, plain) new icon: googlecolab (original, plain) Nov 25, 2023
canaleal
canaleal approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @dariakiseleva.
I've added a new line to each SVG to ensure they're backwards compatible.

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 25, 2023
@canaleal canaleal requested review from a team, ConX, weh, Snailedlt and lunatic-fox and removed request for a team June 23, 2024 01:45
@canaleal canaleal mentioned this pull request Jun 23, 2024
Open
1 task
weh
weh approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@weh weh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to complain, LGTM 👍

@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt merged commit ccc0da3 into devicons:develop Aug 26, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@dariakiseleva @canaleal @Snailedlt
new icon: googlecolab (original, plain) (devicons#2055)
bff5a86 
* New icon: Google Colab

* Added new line to googlecolab original

* Added new line to googlecolab-plain.svg

---------

Co-authored-by: Alex Canales <[email protected]>
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

@weh weh weh approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dariakiseleva @weh @canaleal @Snailedlt