-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: ngrok (original, line) #1891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paths need to be unified since it's an alias for the plain and plain-wordmark versions.
Excellent use of aliases btw!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thank you for another great contribution! 💯 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! And perfect use of aliases! 💯
Thank you for this contribution! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
new icon: ngrok (original, line)
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1801
Link to prove your SVG is correct and up-to-date.
Website Brand: https://ngrok.com/brand
Github: https://github.com/ngrok
Notes
The Ngrok website offers a variety of SVG icons, but their preferred one is the blue 'ngrok' icon with the color
#02228e
.Ngrok does make use of a smaller icon
n
as shown in the brands page, but this is only used for the favicon and literally nowhere else.Given the original icon's simplicity and single color, I set the terms plain, plain-wordmark, and original-wordmark as aliases with the base being "original".