-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: thymeleaf (original, plain, original-wordmark, plain-wordmark) #1705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but a plain or line icon is needed since thymeleaf-original.svg
can not be used as a font, due to multiple paths and fill colors.
If you want to make a line icon, you can follow this guide: #1306 (comment)
Regardless if you choose plain or line, make sure it meets our SVG Standards.
If you want more info on the different SVG versions we use (e.g.) original, plain, line), you can read our SVG Versions wiki page.
aye aye captain |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem.
Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
1 similar comment
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem.
Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was fast. Looks like "font" is the only thing missing
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
It didn't stop at the svgo-action, but the git auto commit action, what happened? |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! ✔
Thank you for this contribution! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a wordmark version for this logo (found it in their downloads page). It'd be great if you could add those as well. 🙂
The other icons look great by the way. Thanks! 🚀
Here's all the official svg logos: https://github.com/thymeleaf/thymeleaf-org/blob/main/artwork/thymeleaf%202016/thymeleaf.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
new icon: thymeleaf (original, plain, original-wordmark, plain-wordmark)
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #1657
Link to prove your SVG is correct and up-to-date.