Skip to content

Commit

Permalink
feat: impl aws plugin
Browse files Browse the repository at this point in the history
Signed-off-by: KeisukeYamashita <[email protected]>
  • Loading branch information
KeisukeYamashita committed Jul 30, 2024
1 parent 5f987a3 commit a249228
Show file tree
Hide file tree
Showing 14 changed files with 1,126 additions and 1 deletion.
22 changes: 22 additions & 0 deletions .github/workflows/lint_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,28 @@ on:
pull_request:

jobs:
aws-lint:
name: aws-lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Run golangci-lint
uses: golangci/golangci-lint-action@v4
with:
working-directory: aws

aws-test:
name: aws-test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
- name: Run Unit tests
run: make test
working-directory: ./aws

azure-lint:
name: azure-lint
runs-on: ubuntu-latest
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ on:
jobs:
goreleaser:
runs-on: ubuntu-latest
strategy:
matrix:
providers:
- aws
- azure
steps:
-
name: Checkout
Expand All @@ -29,7 +34,7 @@ jobs:
with:
version: latest
args: release --clean --debug
workdir: ./azure
workdir: ./${{ matrix.providers }}
env:
KAFKACTL_VERSION: v5.0.6
# create personal access token: https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line
Expand Down
223 changes: 223 additions & 0 deletions aws/.golangci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,223 @@
# config is based on https://gist.github.com/maratori/47a4d00457a92aa426dbd48a18776322

# This file contains only configs which differ from defaults.
# All possible options can be found here https://github.com/golangci/golangci-lint/blob/master/.golangci.reference.yml

run:
# Timeout for analysis, e.g. 30s, 5m.
# Default: 1m
timeout: 3m
skip-files:
- ".*generated.go"

linters-settings:
cyclop:
# The maximal code complexity to report.
# Default: 10
max-complexity: 30
# The maximal average package complexity.
# If it's higher than 0.0 (float) the check is enabled
# Default: 0.0
package-average: 10.0

errcheck:
# Report about not checking of errors in type assertions: `a := b.(MyStruct)`.
# Such cases aren't reported by default.
# Default: false
check-type-assertions: true

exhaustive:
# Program elements to check for exhaustiveness.
# Default: [ switch ]
check:
- switch
- map

exhaustruct:
# List of regular expressions to exclude struct packages and names from check.
# Default: []
exclude:
# std libs
- "^net/http.Client$"
- "^net/http.Cookie$"
- "^net/http.Request$"
- "^net/http.Response$"
- "^net/http.Server$"
- "^net/http.Transport$"
- "^net/url.URL$"
- "^os/exec.Cmd$"
- "^reflect.StructField$"
# public libs
- "^github.com/Shopify/sarama.Config$"
- "^github.com/Shopify/sarama.ProducerMessage$"
- "^github.com/mitchellh/mapstructure.DecoderConfig$"
- "^github.com/prometheus/client_golang/.+Opts$"
- "^github.com/spf13/cobra.Command$"
- "^github.com/spf13/cobra.CompletionOptions$"
- "^github.com/stretchr/testify/mock.Mock$"
- "^github.com/testcontainers/testcontainers-go.+Request$"
- "^github.com/testcontainers/testcontainers-go.FromDockerfile$"
- "^golang.org/x/tools/go/analysis.Analyzer$"
- "^google.golang.org/protobuf/.+Options$"
- "^gopkg.in/yaml.v3.Node$"

funlen:
# Checks the number of lines in a function.
# If lower than 0, disable the check.
# Default: 60
lines: 100
# Checks the number of statements in a function.
# If lower than 0, disable the check.
# Default: 40
statements: 50

gocognit:
# Minimal code complexity to report.
# Default: 30 (but we recommend 10-20)
min-complexity: 20

gocritic:
# Settings passed to gocritic.
# The settings key is the name of a supported gocritic checker.
# The list of supported checkers can be find in https://go-critic.github.io/overview.
settings:
captLocal:
# Whether to restrict checker to params only.
# Default: true
paramsOnly: false
underef:
# Whether to skip (*x).method() calls where x is a pointer receiver.
# Default: true
skipRecvDeref: false

gomnd:
# List of function patterns to exclude from analysis.
# Values always ignored: `time.Date`,
# `strconv.FormatInt`, `strconv.FormatUint`, `strconv.FormatFloat`,
# `strconv.ParseInt`, `strconv.ParseUint`, `strconv.ParseFloat`.
# Default: []
ignored-functions:
- os.Chmod
- os.Mkdir
- os.MkdirAll
- os.OpenFile
- os.WriteFile
- prometheus.ExponentialBuckets
- prometheus.ExponentialBucketsRange
- prometheus.LinearBuckets

gomoddirectives:
# Allow local `replace` directives. Default is false.
replace-local: true

govet:
# Enable all analyzers.
# Default: false
enable-all: true
# Disable analyzers by name.
# Run `go tool vet help` to see all analyzers.
# Default: []
disable:
- fieldalignment # too strict
# Settings per analyzer.
settings:
shadow:
# Whether to be strict about shadowing; can be noisy.
# Default: false
strict: true

nakedret:
# Make an issue if func has more lines of code than this setting, and it has naked returns.
# Default: 30
max-func-lines: 0

nolintlint:
# Exclude following linters from requiring an explanation.
# Default: []
allow-no-explanation: [ funlen, gocognit, lll ]
# Enable to require an explanation of nonzero length after each nolint directive.
# Default: false
require-explanation: true
# Enable to require nolint directives to mention the specific linter being suppressed.
# Default: false
require-specific: true

tenv:
# The option `all` will run against whole test files (`_test.go`) regardless of method/function signatures.
# Otherwise, only methods that take `*testing.T`, `*testing.B`, and `testing.TB` as arguments are checked.
# Default: false
all: true


linters:
disable-all: true
enable:
## enabled by default
- errcheck # checking for unchecked errors, these unchecked errors can be critical bugs in some cases
#- gosimple # specializes in simplifying a code
#- govet # reports suspicious constructs, such as Printf calls whose arguments do not align with the format string
- ineffassign # detects when assignments to existing variables are not used
#- staticcheck # is a go vet on steroids, applying a ton of static analysis checks
#- typecheck # like the front-end of a Go compiler, parses and type-checks Go code
- unused # checks for unused constants, variables, functions and types
## disabled by default
- asciicheck # checks that your code does not contain non-ASCII identifiers
- bidichk # checks for dangerous unicode character sequences
- bodyclose # checks whether HTTP response body is closed successfully
- cyclop # checks function and package cyclomatic complexity
- dupl # tool for code clone detection
- durationcheck # checks for two durations multiplied together
- errname # checks that sentinel errors are prefixed with the Err and error types are suffixed with the Error
- errorlint # finds code that will cause problems with the error wrapping scheme introduced in Go 1.13
#- exhaustive # checks exhaustiveness of enum switch statements
- exportloopref # checks for pointers to enclosing loop variables
- forbidigo # forbids identifiers
- funlen # tool for detection of long functions
- gochecknoinits # checks that no init functions are present in Go code
- gocognit # computes and checks the cognitive complexity of functions
- goconst # finds repeated strings that could be replaced by a constant
- gocritic # provides diagnostics that check for bugs, performance and style issues
- gocyclo # computes and checks the cyclomatic complexity of functions
- godot # checks if comments end in a period
- goimports # in addition to fixing imports, goimports also formats your code in the same style as gofmt
- gomnd # detects magic numbers
- gomoddirectives # manages the use of 'replace', 'retract', and 'excludes' directives in go.mod
- goprintffuncname # checks that printf-like functions are named with f at the end
- gosec # inspects source code for security problems
- lll # reports long lines
- makezero # finds slice declarations with non-zero initial length
- nakedret # finds naked returns in functions greater than a specified function length
- nestif # reports deeply nested if statements
- nilerr # finds the code that returns nil even if it checks that the error is not nil
- nilnil # checks that there is no simultaneous return of nil error and an invalid value
- noctx # finds sending http request without context.Context
- nolintlint # reports ill-formed or insufficient nolint directives
- predeclared # finds code that shadows one of Go's predeclared identifiers
- promlinter # checks Prometheus metrics naming via promlint
- revive # fast, configurable, extensible, flexible, and beautiful linter for Go, drop-in replacement of golint
- tenv # detects using os.Setenv instead of t.Setenv since Go1.17
- tparallel # detects inappropriate usage of t.Parallel() method in your Go test codes
- unconvert # removes unnecessary type conversions
- unparam # reports unused function parameters
- wastedassign # finds wasted assignment statements

issues:
# Maximum count of issues with the same text.
# Set to 0 to disable.
# Default: 3
max-same-issues: 50

exclude-rules:
- source: "(noinspection|TODO)"
linters: [ godot ]
- source: "//noinspection"
linters: [ gocritic ]
- path: "_test\\.go"
linters:
- bodyclose
- dupl
- funlen
- goconst
- gosec
- noctx
- wrapcheck
101 changes: 101 additions & 0 deletions aws/.goreleaser.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
project_name: kafkactl-aws-plugin

before:
hooks:
- go mod download
builds:
- env:
- CGO_ENABLED=0
ldflags:
- -s -w -X main.Version={{.Tag}} -X main.GitCommit={{.ShortCommit}} -X main.BuildTime={{.Date}}
goos:
- darwin
- linux
- windows

archives:
- id: default
format_overrides:
- goos: windows
format: zip
files:
- LICENSE.md
- CHANGELOG.md

checksum:
name_template: "checksums.txt"
nfpms:
- id: default
vendor: Device Insight GmbH
homepage: https://www.device-insight.com/
maintainer: Dirk Wilden <[[email protected]]>
description: AWS Plugin for kafkactl
license: Apache 2.0

formats:
- deb
- rpm

release:
disable: false
draft: false

brews:
- tap:
owner: deviceinsight
name: homebrew-packages

commit_author:
name: goreleaserbot
email: [email protected]

folder: Formula

homepage: https://www.device-insight.com/

dependencies:
- name: kafkactl

description: aws Plugin for kafkactl
skip_upload: false

winget:
- name: kafkactl-aws-plugin
publisher: deviceinsight
short_description: AWS Plugin for kafkactl
license: Apache-2.0
publisher_support_url: https://github.com/deviceinsight/kafkactl-plugins/issues
package_identifier: deviceinsight.kafkactl-aws-plugin
homepage: https://www.device-insight.com/
repository:
owner: deviceinsight
name: winget-pkgs
branch: "kafkactl-aws-plugin-{{.Version}}"
pull_request:
enabled: true
base:
owner: microsoft
name: winget-pkgs
branch: master

dockers:
- skip_push: false
dockerfile: Dockerfile.Ubuntu
build_flag_templates:
- "--build-arg=KAFKACTL_VERSION={{ .Env.KAFKACTL_VERSION }}"
image_templates:
- "deviceinsight/kafkactl-aws:latest-{{ .Env.KAFKACTL_VERSION }}-ubuntu"
- "deviceinsight/kafkactl-aws:{{ .Tag }}-{{ .Env.KAFKACTL_VERSION }}-ubuntu"
- skip_push: false
dockerfile: Dockerfile.Scratch
build_flag_templates:
- "--build-arg=KAFKACTL_VERSION={{ .Env.KAFKACTL_VERSION }}"
image_templates:
- "deviceinsight/kafkactl-aws:latest-{{ .Env.KAFKACTL_VERSION }}-scratch"
- "deviceinsight/kafkactl-aws:{{ .Tag }}-{{ .Env.KAFKACTL_VERSION }}-scratch"
#publishers:
# - name: aur-aws
# env:
# - AUR_SSH_PRIVATE_KEY={{ .Env.AUR_SSH_PRIVATE_KEY }}
# cmd: |
# .github/aur/aws/publish.sh {{ .Version }}
12 changes: 12 additions & 0 deletions aws/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## 1.0.0 - 2024-07-31

### Added

Initial Release
4 changes: 4 additions & 0 deletions aws/Dockerfile.Scratch
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
ARG KAFKACTL_VERSION
FROM deviceinsight/kafkactl:${KAFKACTL_VERSION}-scratch
COPY kafkactl-aws-plugin /usr/local/bin
ENTRYPOINT ["/kafkactl"]
4 changes: 4 additions & 0 deletions aws/Dockerfile.Ubuntu
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
ARG KAFKACTL_VERSION
FROM deviceinsight/kafkactl:${KAFKACTL_VERSION}-ubuntu
COPY kafkactl-aws-plugin /usr/local/bin
ENTRYPOINT ["/kafkactl"]
Loading

0 comments on commit a249228

Please sign in to comment.