TMS-1052: Favorite programs #182
Conversation
assets/scripts/program-favorite.js
Outdated
| const $ = jQuery; | ||
|
|
||
| /** | ||
| * Class LoadMore |
assets/scripts/program-favorite.js
Outdated
| @@ -0,0 +1,280 @@ | |||
| /* eslint-disable no-console */ | |||
| /** | |||
| * Load more functionality for koulutusnosto-component. | |||
| * Class LoadMore | ||
| */ | ||
| export default class FavoritePrograms { | ||
| docReady() { |
There was a problem hiding this comment.
Näille parille metodille vois heittää docblock-kommentin vielä
| * Initialize functionalities common for all templates. | ||
| */ | ||
| initCommon() { | ||
| this.favoriteButtons = $( this.selectors.button ); |
There was a problem hiding this comment.
Kaikki luokan variablejen asetukset kannattaisi olla tossa cache metodissa.
| this.loadFavorites(); | ||
| } ); | ||
|
|
||
| $( document ).on( 'click', '.js-remove-favorite', ( e ) => { |
There was a problem hiding this comment.
Voisiko tällä classilla tehdä myös jonkun this.removeFavoriteButtonsin ja tehdä event listenerin samalla tavalla kuin tossa yllä?
There was a problem hiding this comment.
Piti toteuttaa tälleen, koska .js-remove-favorite painikkeet tulee dynaamisesti listaukseen yksittäisen suosikki-itemin mukana
models/shared/program-favorites.php
Outdated
| foreach ( $program_ids as $key => $post_id ) { | ||
| // ID | ||
| $posts[ $key ]['ID'] = $post_id; | ||
|
|
||
| // Program title | ||
| $posts[ $key ]['title'] = \get_the_title( $post_id ); | ||
|
|
||
| // Comma separated program-type terms | ||
| $term_obj_list = \get_the_terms( $post_id, 'program-type' ); | ||
| $terms_string = join( ', ', wp_list_pluck( $term_obj_list, 'name' ) ); | ||
| $posts[ $key ]['program_types'] = $terms_string; | ||
|
|
||
| // Dates | ||
| $posts[ $key ]['start_date'] = date( "d.m.Y", strtotime( \get_field( 'start_date', $post_id ) ) ); | ||
| $posts[ $key ]['start_info'] = \get_field( 'start_info', $post_id ); | ||
|
|
||
| // Permalink | ||
| $posts[ $key ]['permalink'] = \get_the_permalink( $post_id ); | ||
|
|
||
| // Texts | ||
| $posts[ $key ]['remove_favorite_text'] = \_x( 'Remove from favorites', 'theme-frontend', 'tms-theme-tredu' ); | ||
| $posts[ $key ]['go_to_program_text'] = \_x( 'Go to program', 'theme-frontend', 'tms-theme-tredu' ); | ||
| } |
There was a problem hiding this comment.
Tämä voisi olla myös vähän selkeämpi näin:
$term_obj_list = ...
$terms_string = ...
$posts[ $key ][] = [
'ID' => $post_id,
'title' => \get_the_title( $post_id ),
// jne.
];
Toi $posts[ $key ]['jotain'] toisto on vähän turhaa.
| <button id="js-favorites-open" | ||
| class="is-rounded button js-toggle is-outlined p-0 ml-2" | ||
| aria-controls="js-favorites-container" | ||
| aria-expanded="false" |
There was a problem hiding this comment.
Olin kattovinani, että tätä ei ikinä asetettaisi trueksi, vaikka nappia painaisi? Tän vois vielä varmistaa.
There was a problem hiding this comment.
Tää tapahtuu jo valmiina olevassa toggle.js tiedostossa
| <div class="button-container"> | ||
| <a href="{permalink|url}" class="button is-primary">{go_to_program_text|html}</a> | ||
| <button | ||
| data-program-id={ID|attr} |
There was a problem hiding this comment.
| data-program-id={ID|attr} | |
| data-program-id="{ID|attr}" |
| @@ -0,0 +1,11 @@ | |||
| <button data-program-id={program_id|attr} | |||
There was a problem hiding this comment.
| <button data-program-id={program_id|attr} | |
| <button data-program-id="{program_id|attr}" |
| <svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 516 516"> | ||
| <path fill="transparent" stroke="#042546" stroke-width="50" d="M47.6 300.4L228.3 469.1c7.5 7 17.4 10.9 27.7 10.9s20.2-3.9 27.7-10.9L464.4 300.4c30.4-28.3 47.6-68 47.6-109.5v-5.8c0-69.9-50.5-129.5-119.4-141C347 36.5 300.6 51.4 268 84L256 96 244 84c-32.6-32.6-79-47.5-124.6-39.9C50.5 55.6 0 115.2 0 185.1v5.8c0 41.5 17.2 81.2 47.6 109.5z"/> | ||
| </svg> |
There was a problem hiding this comment.
Tää olis parempi jos saisi ikoniksi ja sitä kautta includattua partiaalista
Severa-ID: 2132
Severa-kuvaus: TMS-1052 Suosikki-merkkaustoiminto
Task: https://hiondigital.atlassian.net/browse/TMS-1052
Description
Favorite program-functionalities
Types of changes