TMS-1050: Accordion script fixes #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HPiirainen
approved these changes
Jun 10, 2024
assets/scripts/accordion.js
Outdated
| if ( ! dropdowns[ i ].classList.contains( 'active-accordion' ) ) { | ||
| dropdowns[ i ].classList.add( 'active-accordion' ); | ||
| } | ||
| if ( dropdowns.length >= 1 ) { |
There was a problem hiding this comment.
Yleensä selkeämpi > 0, mutta ei tarvi muuttaa, koska sama asia.
There was a problem hiding this comment.
Tosin tässä voisi olla järkevämpi early return
if ( dropdowns.length === 0 ) {
return;
}
for (...
assets/scripts/accordion.js
Outdated
| if ( dropdowns[ i ].classList.contains( 'active-accordion' ) ) { | ||
| dropdowns[ i ].classList.remove( 'active-accordion' ); | ||
| } | ||
| if ( dropdowns.length >= 1 ) { |
There was a problem hiding this comment.
Tähänkin mieluummin early return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severa-ID: 2247
Severa-kuvaus: TMS-1050 Tredun Koulutukset-sivun hakuvalintahaitari ei aukea
Task: https://hiondigital.atlassian.net/browse/TMS-1050
Description
Add if-statements and checks to prevent breaking other accordion-elements.
Motivation and Context
The new accordion script broke the functionality of an accordion-element in Tredu's program-search page template.
Types of changes