Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMS-1015: Header accessibility fixes #171

Merged
merged 2 commits into from
Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.MD
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [1.8.10] - 2024-03-18

- TMS-1015: Header accessibility fixes

## [1.8.9] - 2024-02-01

- TMS-980: Add redipress_include_search to include component contents in search results
Expand Down
4 changes: 2 additions & 2 deletions partials/shared/header-inner.dust
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@

{?Header.lang_nav_horizontal}
<div class="is-hidden-touch">
{>"ui/menu/language-nav" links=Header.language_nav.links /}
{>"ui/menu/language-nav" links=Header.language_nav.links id="lang-menu" /}
</div>
{/Header.lang_nav_horizontal}

{?Header.lang_nav_horizontal}
<div class="is-hidden-desktop">
{?Header.language_nav.links_without_current}
{>"ui/menu/language-nav" links=Header.language_nav.links_without_current /}
{>"ui/menu/language-nav" links=Header.language_nav.links_without_current id="lang-menu-mobile" /}
{:else}
{>"ui/menu/language-nav-dropdown" links=Header.language_nav.links /}
{/Header.language_nav.links_without_current}
Expand Down
2 changes: 1 addition & 1 deletion partials/ui/menu/language-nav.dust
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{?links.all}
<nav aria-label="{Strings.s.header.language_navigation|s}">
<ul id="lang-menu"
<ul id="{id|attr}"
class="lang-nav--horizontal ml-6-desktop is-flex is-unstyled is-uppercase has-text-weight-semibold is-family-secondary">
{#links.all}
<li class="ml-2-desktop">
Expand Down
2 changes: 1 addition & 1 deletion style.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Theme Name: TMS Theme Tredu
* Description: Tampere Multisite Tredu Theme
* Domain Path: /lang
* Version: 1.8.9
* Version: 1.8.10
* Author: Geniem
* Author URI: https://geniem.fi
* Text Domain: tms-theme-tredu
Expand Down
Loading