Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to modules #23

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Refactor to modules #23

merged 3 commits into from
Oct 4, 2024

Conversation

gadomski
Copy link
Collaborator

@gadomski gadomski commented Oct 4, 2024

  • Split out most structs and enums to modules. I find that this helps to keep good abstractions and to ensure we're intentional about what we provide in the public API
  • Remove parse in favor of implementing FromStr for Expr

@gadomski gadomski self-assigned this Oct 4, 2024
kylebarron
kylebarron approved these changes Oct 4, 2024
View reviewed changes
src/error.rs Show resolved Hide resolved
src/parser.rs Show resolved Hide resolved
@gadomski gadomski merged commit dcd0ffe into main Oct 4, 2024
1 check passed
@gadomski gadomski deleted the refactor branch October 4, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitner bitner bitner left review comments

@kylebarron kylebarron kylebarron approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gadomski @bitner @kylebarron