Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename to_cql2_text to to_text, check expression argument length #21

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Rename to_cql2_text to to_text, check expression argument length #21

merged 5 commits into from
Oct 2, 2024

Conversation

gadomski
Copy link
Collaborator

@gadomski gadomski commented Oct 2, 2024

What I am changing

  • Rename to_cql2_text to to_text -- the other method is to_json (not to_cql2_json) so thought we should align
  • Add some length checking to expressions to throw errors if there's extra or too-few arguments (e.g. between should be 3 arguments)
  • A little light refactoring of some helper methods to work w/ chars instead of bytes

@gadomski gadomski requested a review from bitner October 2, 2024 12:15
@gadomski gadomski self-assigned this Oct 2, 2024
@bitner bitner merged commit eafe584 into main Oct 2, 2024
1 check passed
@bitner bitner deleted the audit branch October 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitner bitner bitner approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @bitner