Skip to content

Commit

Permalink
[javascript-node & typescript-node] Bump npm version due to GHSA-c2…
Browse files Browse the repository at this point in the history
…qf-rxjj-qqgw (#677)

* [javascript-node & typescript-node] Bump `npm` version due to GHSA-c2qf-rxjj-qqgw

* Restart checks

* Revert "[javascript-node & typescript-node] Bump `npm` version due to GHSA-c2qf-rxjj-qqgw"

This reverts commit df96833.

* Revert "Revert "[javascript-node & typescript-node] Bump `npm` version due to GHSA-c2qf-rxjj-qqgw""

This reverts commit 63c86e5.

* Add test to verify `npm` version

* Reorg tests

* Restart checks

* Restart checks

* Restart checks
  • Loading branch information
alexander-smolyakov authored Jul 27, 2023
1 parent c3eb552 commit 0f0973a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/javascript-node/.devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ ARG NPM_GLOBAL=/usr/local/share/npm-global
# Add NPM global to PATH.
ENV PATH=${NPM_GLOBAL}/bin:${PATH}

# [Temporal] Bump npm version due to GHSA-c2qf-rxjj-qqgw
RUN npm install -g [email protected]

RUN \
# Configure global npm install location, use group to adapt to UID/GID changes
if ! cat /etc/group | grep -e "^npm:" > /dev/null 2>&1; then groupadd -r npm; fi \
Expand Down
2 changes: 2 additions & 0 deletions src/javascript-node/test-project/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ checkCommon

# Image specific tests
check "node" node --version
npm_version=$(npm --version)
check-version-ge "npm-requirement" "${npm_version}" "9.8.1"
sudo rm -f yarn.lock
check "yarn" yarn install
sudo rm -f package-lock.json
Expand Down

0 comments on commit 0f0973a

Please sign in to comment.