Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution to cli issue - TypeError: Cannot read properties of undefined (reading 'fsPath') #895 #924

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

solution to cli issue - TypeError: Cannot read properties of undefined (reading 'fsPath') #895 #924

wants to merge 7 commits into from

Conversation

gauravsaini04
Copy link
Contributor

ref: #895

Description

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner October 28, 2024 23:35
@gauravsaini04 gauravsaini04 mentioned this pull request Oct 28, 2024
Open
chrmarti
chrmarti requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, left a comment for a possible improvement.

src/spec-node/featuresCLI/resolveDependencies.ts Outdated Show resolved Hide resolved
chrmarti
chrmarti requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small ask, otherwise ready for merging. Thanks.

src/spec-node/featuresCLI/resolveDependencies.ts Outdated Show resolved Hide resolved
chrmarti
chrmarti approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gauravsaini04
Copy link
Contributor Author

LGTM!

Hi @chrmarti, as I don't have merging authorization, could you pls merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshspicer joshspicer joshspicer approved these changes

@chrmarti chrmarti chrmarti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gauravsaini04 @chrmarti @joshspicer