Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'templates metadata' subcommand #866

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

joshspicer
Copy link
Member

Follow up to #865. Exposes Template metadata cached on a manifest with the templates metadata subcommand

Also relevant for microsoft/vscode-remote-release#10095, by allowing tools to query the metadata of a Template before downloading its contents.

image

@joshspicer joshspicer requested a review from a team as a code owner August 1, 2024 17:06
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, should we add some test coverage?

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshspicer joshspicer merged commit ed43a5b into main Aug 12, 2024
37 checks passed
@joshspicer joshspicer deleted the joshspicer/template-metadata branch August 12, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants