redundant dockerfile issue with build #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathameshzarkar9
force-pushed
the
redundant-dockerfile-build-image-name
branch
from
dbc7562
to
951d1f1
Compare
samruddhikhandale
requested changes
Apr 26, 2024
prathameshzarkar9
force-pushed
the
redundant-dockerfile-build-image-name
branch
4 times, most recently
from
9b75a1a
to
16d9d10
Compare
samruddhikhandale
requested changes
Apr 29, 2024
chrmarti
requested changes
Apr 30, 2024
prathameshzarkar9
force-pushed
the
redundant-dockerfile-build-image-name
branch
from
16d9d10
to
9b10555
Compare
samruddhikhandale
requested changes
May 1, 2024
prathameshzarkar9
force-pushed
the
redundant-dockerfile-build-image-name
branch
from
9b10555
to
ad05d1d
Compare
chrmarti
requested changes
May 2, 2024
prathameshzarkar9
force-pushed
the
redundant-dockerfile-build-image-name
branch
from
ad05d1d
to
b80617f
Compare
|
@prathameshzarkar9 I see you removed the test. Our hope was that we could have the test just without the |
prathameshzarkar9
force-pushed
the
redundant-dockerfile-build-image-name
branch
from
b80617f
to
92e51fa
Compare
prathameshzarkar9
force-pushed
the
redundant-dockerfile-build-image-name
branch
from
92e51fa
to
de4d1bf
Compare
samruddhikhandale
requested changes
May 15, 2024
prathameshzarkar9
force-pushed
the
redundant-dockerfile-build-image-name
branch
from
de4d1bf
to
f90f8a7
Compare
samruddhikhandale
requested changes
May 15, 2024
samruddhikhandale
requested changes
May 17, 2024
samruddhikhandale
approved these changes
May 22, 2024
There was a problem hiding this comment.
Looks good to me!
@chrmarti Can you help take another peek? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#791 Redundant Dockerfile required in order to push to correct repo
if we pass this argument value then it is stored in the additionaImageNames parameter which is used to check the additional names are provided. if yes, then it should not use cli-generated-image accordingly modification have been incorporated.