Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cache on feature build when --build-no-cache is passed #790

Merged
merged 8 commits into from
Apr 15, 2024
Merged

Disable cache on feature build when --build-no-cache is passed #790

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
118d4ce
Disable cache on feature build when specified
robjackstewart Apr 2, 2024
6adb74c
dont check --no-cache arg in case of --cache-to
robjackstewart Apr 10, 2024
e766ad9
Add test for --no-cache
robjackstewart Apr 10, 2024
f3b2df7
Assert based on layer shas
robjackstewart Apr 12, 2024
a540f83
add 'because' statements
robjackstewart Apr 12, 2024
a0943d9
extract base image layers from built image layers
robjackstewart Apr 12, 2024
b7e6236
remove only
robjackstewart Apr 12, 2024
1d9a38c
Merge branch 'main' into control-cache-for-features
robjackstewart Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/spec-node/containerFeatures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export async function extendImage(params: DockerResolverParameters, config: Subs
args.push('--load'); // (short for --output=docker, i.e. load into normal 'docker images' collection)
}
}
if (params.buildxCacheTo) {
if (params.buildxCacheTo && !params.buildNoCache) {
samruddhikhandale marked this conversation as resolved.
Show resolved Hide resolved
args.push('--cache-to', params.buildxCacheTo);
}

Expand All @@ -95,6 +95,9 @@ export async function extendImage(params: DockerResolverParameters, config: Subs
'build',
);
}
if (params.buildNoCache) {
args.push('--no-cache');
}
for (const buildArg in featureBuildInfo.buildArgs) {
args.push('--build-arg', `${buildArg}=${featureBuildInfo.buildArgs[buildArg]}`);
}
Expand Down