Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate test failures #781

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Investigate test failures #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/container-features/configs/dockerfile-with-v2-oci-features/.devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
},
"features": {
"terraform": "latest",
"ghcr.io/devcontainers/features/docker-in-docker@sha256:e32e8937c87345ff7a937d22cacb7f395d41deffde9943291ef3cc0ac91a8ac6": {},
"ghcr.io/devcontainers/features/docker-in-docker@sha256:440bdb81cf8af43f3e922450d33db9775c1097340557a5b7b6fe705bc758c5ef": {},
chrmarti marked this conversation as resolved.
Show resolved Hide resolved
"node": "16"
}
}
4 changes: 4 additions & 0 deletions src/test/container-features/e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,12 @@ describe('Dev Container Features E2E (remote)', function () {
for (let i = 2; i >= 0; i--) {
try {
const res = await shellExec(`${cli} exec --workspace-folder ${testFolder} docker ps`);
await shellExec(`${cli} exec --workspace-folder ${testFolder} ps ax`);
assert.isNull(res.error);
assert.match(res.stdout, /CONTAINER ID/);
break;
} catch (err) {
await shellExec(`${cli} exec --workspace-folder ${testFolder} ps ax`);
if (i === 0) {
throw err;
}
Expand Down Expand Up @@ -111,10 +113,12 @@ describe('Dev Container Features E2E (remote)', function () {
for (let i = 2; i >= 0; i--) {
try {
const res = await shellExec(`${cli} exec --workspace-folder ${testFolder} docker ps`);
await shellExec(`${cli} exec --workspace-folder ${testFolder} ps ax`);
assert.isNull(res.error);
assert.match(res.stdout, /CONTAINER ID/);
break;
} catch (err) {
await shellExec(`${cli} exec --workspace-folder ${testFolder} ps ax`);
if (i === 0) {
throw err;
}
Expand Down
Loading