Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authentication against Artifactory #692

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix authentication against Artifactory #692

merged 1 commit into from
Nov 27, 2023

Commits on Nov 27, 2023

  1. Fix authentication against Artifactory 

    To authenticate against an OCI registry the code currently requires a
`scope` attribute in the `WWW-Authenticate` header. This key is optional
according to RFC 6750 [1], an empty string can be used if it's not
present.

Artifactory does not include the `scope` attribute and hence
authentication fails currently. Fix that by making the attribute
optional.

[1] "Use of the "scope" attribute is OPTIONAL."

Fixes devcontainers#691
    @imphil
    imphil committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    dc41f2f View commit details
    Browse the repository at this point in the history