Fix #543: build with correct image names #586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Method `extendImage` created image with the default name ignoring `--image-name` option. - The image could not be tagged after building, because CLI exited with `ERROR: denied: requested access to the resource is denied` after pushing attempt. - Added image names from `--image-names` option at building stage.
|
@microsoft-github-policy-service agree |
3 tasks
joshspicer
reviewed
Jul 26, 2023
| @@ -90,14 +88,18 @@ export async function extendImage(params: DockerResolverParameters, config: Subs | |||
| for (const buildArg in featureBuildInfo.buildArgs) { | |||
| args.push('--build-arg', `${buildArg}=${featureBuildInfo.buildArgs[buildArg]}`); | |||
| } | |||
|
|
|||
| const folderImageName = getFolderImageName(common); | |||
| const updatedImageName: string[] = imageNames ?? [`${imageName.startsWith(folderImageName) ? imageName : folderImageName}-features`]; | |||
There was a problem hiding this comment.
Looking quickly at CI, I think imageName might need a null check here?
Alirakz181016
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Hi @invasy 👋
Apologies on missing out on this PR, would you be still interested in checking this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #543
Problem
extendImagecreated image with the default name ignoring--image-nameoption.ERROR: denied: requested access to the resource is deniedafter pushing attempt.Solution
--image-namesoption at building stage.