Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Terminal-Icons.format.ps1xml to format Length property #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DBremen
Copy link

@DBremen DBremen commented Sep 26, 2019

Modified Terminal-Icons.format.ps1xml to format output of Length property into B|KB|MB|GB respectively.

Description

This adds a formatted Length output for files and directories (including sub-folders). Makes the output slower (though it's reasonably fast even for bigger folders), but also adds useful more readable info.

Related Issue

#9

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@devblackops devblackops self-requested a review October 18, 2019 04:41
@devblackops devblackops self-assigned this Oct 18, 2019
@devblackops devblackops added the enhancement New feature or request label Oct 18, 2019
@devblackops
Copy link
Owner

Hi @DBremen. I like this but I think adding size info to folders with recursive traversals slows things down too much. Perhaps we can add some basic configuration system to Terminal-Icons so the user can elect to enable this feature if they wish. As it stands right now, I'm not going to merge this until we have a way to optionally enable it. Hope you understand.

@DBremen
Copy link
Author

DBremen commented Oct 19, 2019

sure no worries.

@rashil2000
Copy link
Contributor

@DBremen @devblackops Perhaps we can have the size display (KB|MB|GB) for just files for now? That would still be helpful.

@cdhunt
Copy link
Contributor

cdhunt commented Apr 9, 2021

I've prototyped out a format file that combines Terminal-Icons and PowershellHumanizer.

https://gist.github.com/cdhunt/62069848ed81f371d4c760b0c5465d09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants