Cookstyle Bot Auto Corrections with Cookstyle 7.30.1 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cookstyle[bot]](https://avatars.githubusercontent.com/in/78849?s=60&v=4){kind=small}
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.30.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client. ### Style/Encoding - **/Berksfile:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/Gemfile:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/Guardfile:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/Rakefile:2**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/attributes/default.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/attributes/hardening.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/metadata.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/recipes/default.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/recipes/hardening.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/spec/spec_helper.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/spec/unit/recipes/default_spec.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/spec/unit/recipes/hardening_spec.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) ### Style/RegexpLiteral - **/Guardfile:7**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:11**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:12**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:13**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:14**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:19**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:20**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:25**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:26**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:27**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:28**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:29**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:30**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) - **/Guardfile:31**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) ### Chef/Style/CommentFormat - **/attributes/default.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/attributes/default.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/attributes/default.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/attributes/hardening.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/attributes/hardening.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/attributes/hardening.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/metadata.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/default.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/default.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/default.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/hardening.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/hardening.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/hardening.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/spec_helper.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) ### Layout/CaseIndentation - **/attributes/default.rb:32**: Indent `when` as deep as `case`. (https://rubystyle.guide#indent-when-to-case) ### Style/ConditionalAssignment - **/attributes/default.rb:32**: Use the return of the conditional for variable assignment and comparison. ### Layout/IndentationWidth - **/attributes/default.rb:33**: Use 2 (not -41) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/attributes/default.rb:35**: Use 2 (not -41) spaces for indentation. (https://rubystyle.guide#spaces-indentation) ### Layout/ElseAlignment - **/attributes/default.rb:34**: Align `else` with `when`. ### Chef/Sharing/InvalidLicenseString - **/metadata.rb:21**: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers. (https://docs.chef.io/workstation/cookstyle/chef_sharing_invalidlicensestring) ### Chef/RedundantCode/LongDescriptionMetadata - **/metadata.rb:23**: The long_description metadata.rb method is not used and is unnecessary in cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_longdescriptionmetadata) ### Chef/RedundantCode/RecipeMetadata - **/metadata.rb:28**: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_recipemetadata) - **/metadata.rb:29**: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_recipemetadata) ### Chef/Style/IncludeRecipeWithParentheses - **/recipes/default.rb:22**: There is no need to wrap the recipe in parentheses when using the include_recipe helper (https://docs.chef.io/workstation/cookstyle/#includerecipewithparentheses) ### Layout/TrailingEmptyLines - **/spec/spec_helper.rb:23**: 1 trailing blank lines detected. (https://rubystyle.guide#newline-eof) ### Chef/Deprecations/ChefSpecCoverageReport - **/spec/spec_helper.rb:24**: Don't use the deprecated ChefSpec coverage report functionality in your specs. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_chefspeccoveragereport) ### Layout/DotPosition - **/spec/unit/recipes/hardening_spec.rb:11**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/unit/recipes/hardening_spec.rb:20**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/unit/recipes/hardening_spec.rb:28**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) Signed-off-by: Cookstyle <[email protected]>
|
Closing this pull request as it has been superseded by #37, which was created with Cookstyle 7.31.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.30.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client.
Style/Encoding
Style/RegexpLiteral
%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)%raround regular expression. (https://rubystyle.guide#percent-r)Chef/Style/CommentFormat
Layout/CaseIndentation
whenas deep ascase. (https://rubystyle.guide#indent-when-to-case)Style/ConditionalAssignment
Layout/IndentationWidth
Layout/ElseAlignment
elsewithwhen.Chef/Sharing/InvalidLicenseString
Chef/RedundantCode/LongDescriptionMetadata
Chef/RedundantCode/RecipeMetadata
Chef/Style/IncludeRecipeWithParentheses
Layout/TrailingEmptyLines
Chef/Deprecations/ChefSpecCoverageReport
Layout/DotPosition
Signed-off-by: Cookstyle [email protected]