Keep cache of passwords changed during request so we won't trigger twice

despark · Aug 6, 2018 · 4013406 · 4013406
1 parent 19eaee8
commit 4013406
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/EventListener/PasswordEntityListener.php b/src/EventListener/PasswordEntityListener.php
@@ -39,6 +39,11 @@ class PasswordEntityListener
      */
     private $processedNewEntities = [];
 
+    /**
+     * @var array
+     */
+    private $processedPasswords =[];
+
     /**
      * PasswordEntityListener constructor.
      * @param \Despark\PasswordPolicyBundle\Service\PasswordHistoryServiceInterface $passwordHistoryService
@@ -118,6 +123,10 @@ public function createPasswordHistory(
             return null;
         }
 
+        if(array_key_exists($oldPassword, $this->processedPasswords)){
+            return null;
+        }
+
         $uow = $em->getUnitOfWork();
         $entityMeta = $em->getClassMetadata(get_class($entity));
 
@@ -145,6 +154,7 @@ public function createPasswordHistory(
 
         $entity->addPasswordHistory($history);
 
+        $this->processedPasswords[$oldPassword] = $history;
 
         $stalePasswords = $this->passwordHistoryService->getHistoryItemsForCleanup($entity, $this->historyLimit);