Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle GCM under bin #512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bundle GCM under bin #512

wants to merge 1 commit into from

Conversation

niik
Copy link
Member

@niik niik commented Jun 11, 2024

After talking with @dscho I now know that we shouldn't be sticking arbitrary stuff into libexec/git-core, that's reserved for... ya know... git-core.

So I've moved the git credential manager into the bin/ folder as per Johannes suggestion. We still drop Git LFS into libexec/git-core and I guess we should stop doing that as well but we've had LFS in there forever so let's start with just GCM and tackle LFS in a follow-up PR.

Co-Authored-By: Johannes Schindelin <[email protected]>
Copy link

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need any change in how git is called, i.e. augmenting the PATH so that the executables in bin will be found?

@niik
Copy link
Member Author

niik commented Jan 20, 2025

Does this need any change in how git is called, i.e. augmenting the PATH so that the executables in bin will be found?

Came back to merge this and looked into this. TL;DR, yes, we need to amend the PATH for macOS and Linux. On Windows we already add the bin folder to the PATH: https://github.com/desktop/dugite/blob/8da03595ab67e7796d3741a556de39aa7b0f35df/lib/git-environment.ts#L91-L99. Gonna hold off on merging this until we're ready on the dugite side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants