Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bare-bones README #35

Closed
wants to merge 1 commit into from
Closed

Conversation

Newbytee
Copy link

@Newbytee Newbytee commented Nov 7, 2020

Only contains information about dependencies necessary for building on Linux. I wouldn't say that this does what's necessary for #28 to be closed as it doesn't really explain what the library is for.

Only contains information about dependencies necessary for building on Linux. I wouldn't say that this does what's necessary for desktop-app#28 to be closed as it doesn't really explain what the library is for.
@xloem
Copy link

xloem commented Jan 22, 2021

@xvitaly @ilya-fedin what do you think of this PR? We could add the protobuf version to it from #43 (comment) .

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Jan 22, 2021

I think there should be information about that this is a fork of https://github.com/open-webrtc-toolkit/owt-deps-webrtc that is a fork of https://webrtc.github.io/webrtc-org/native-code/ with changes only for cmake build and all contributions and issues about the code should go to https://github.com/open-webrtc-toolkit/owt-deps-webrtc/issues https://github.com/open-webrtc-toolkit/owt-deps-webrtc/pulls or to https://webrtc.github.io/webrtc-org/bugs/ https://webrtc.github.io/webrtc-org/contributing/ either, while tg_owt issues and PRs are only about problems with cmake files.

Probably it's also worth to mention that the only "officially" supported target for Linux is x86_64 static build, while shared build and support for all other architectures is community maintained and may break from time to time due to any needed changes until someone interested fix it.

@ilya-fedin
Copy link
Contributor

@Newbytee will you continue to work on this or the PR can be closed?

@Newbytee
Copy link
Author

@Newbytee will you continue to work on this or the PR can be closed?

I had forgotten about this PR. I could address the complaints, but I would like some indication from Preston that he would merge this should they be addressed as right now he hasn't involved himself the slightest.

@ilya-fedin
Copy link
Contributor

What if we document building tdesktop in DESKTOP_APP_USE_PACKAGED mode with all its dependencies instead of documenting here? tg_owt build process really depends on how you build the app consuming it (special target, internal audio backends and etc).

@ilya-fedin
Copy link
Contributor

Finally, I documented my packaged building mode in tdesktop wiki
https://github.com/telegramdesktop/tdesktop/wiki/The-Packaged-Building-Mode

Feel free to close the PR if this info is enough.

@Newbytee
Copy link
Author

Looks good to me 👍. I still find it a bit odd that this repo doesn't explain itself, but at least it's explained there now to someone building Telegram themselves.

@Newbytee Newbytee closed this Oct 11, 2021
@milahu milahu mentioned this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants