Only save user-assigned order addresses if they are not new records. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't try to save invalid addresses and reenable merging.
|
This looks good. I like the checks. In the heat of the moment I couldn't see the proper way to fix this but I like these. 🐼 |
It currently fails.
Checking out part way as a guest, then starting over (and possibly logging in before starting over) could at one point cause blank addresses to be saved to the database.
|
This PR is, in part, a workaround for spree/spree_auth_devise#300 |
|
Looks good 🐼 |
mike-bourgeous
added a commit
that referenced
this pull request
Sep 30, 2015
Only save user-assigned order addresses if they are not new records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't try to save invalid addresses and reenable merging.