chore: test axe examples in ci #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scurker
force-pushed
the
test-doc-examples
branch
6 times, most recently
from
86b0e1c
to
135bf00
Compare
scurker
force-pushed
the
test-doc-examples
branch
from
a6ca7d4
to
4c9afff
Compare
stephenmathieson
requested changes
Mar 18, 2019
stephenmathieson
requested changes
Mar 18, 2019
|
It looks like running the examples only takes ~15s, so optimizing it probably isn't necessary.
|
scurker
force-pushed
the
test-doc-examples
branch
from
a877eff
to
b874fd8
Compare
stephenmathieson
requested changes
Mar 18, 2019
scurker
force-pushed
the
test-doc-examples
branch
from
b874fd8
to
e575103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get examples in
doc/examplesrunning on CI:Chrome Debugging Protocol(needs to spin up separate instance of chrome)(Existing Issue on CircleCI/Travis #295)Swapped to Karma to run Jasmine specsAdded script to run all examples under
doc/examples/*. Added appveyor config to have examples running on windows.Reviewer checks
Required fields, to be filled out by PR reviewer(s)