Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(http): uuid setting cookie 사용하도록 변경 #391

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

chaaerim
Copy link
Member

💡 왜 PR을 올렸나요?

  • 서버컴포넌트 대응을 위해 uuid 저장소를 localStorage에서 cookie를 사용하도록 변경했습니다.

💁 무엇이 어떻게 바뀌나요?

💬 리뷰어분들께

@LineGu LineGu enabled auto-merge (squash) January 14, 2024 04:37
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (43c2566) 0.08% compared to head (d815d52) 0.08%.

Files Patch % Lines
src/common/utils/http.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/routing    #391      +/-   ##
==================================================
- Coverage             0.08%   0.08%   -0.01%     
==================================================
  Files                  164     164              
  Lines                 5933    5934       +1     
  Branches               164     164              
==================================================
  Hits                     5       5              
- Misses                5928    5929       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaaerim chaaerim changed the title refactor: uuid setting cookie 사용하도록 변경 refactor(http): uuid setting cookie 사용하도록 변경 Jan 14, 2024
@LineGu LineGu merged commit 7d2a3ba into release/routing Jan 14, 2024
4 checks passed
@LineGu LineGu deleted the refactor/uuid branch January 14, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants