Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor(all): change module name depromeet to streetdrop #312

Closed
wants to merge 1 commit into from

Conversation

seonghun-dev
Copy link
Collaborator

No description provided.

Copy link
Member

@siyeonSon siyeonSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇게 디프만의 흔적은 사라지고..

image

@@ -27,7 +27,7 @@ public List<ItemPointDao> findNearItemsPointsByDistance(Point point, Double dist
itemLocation.point,
item.id,
albumCover.albumThumbnail,
mySqlDistanceSphereFunction(itemLocation.point, point)
MySqlSpatialFunction.mySqlDistanceSphereFunction(itemLocation.point, point)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryDSL 이 부분도 의도된 변경일까요?

import com.streetdrop.music.artist.Artist;
import com.streetdrop.music.song.Song;

public record MusicDto(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MusicDto는 신규 추가일까요?

}



Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MusicService도 신규 추가되는걸까요?

Copy link
Collaborator

@yunyoung1819 yunyoung1819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 Good!

Copy link
Collaborator

@yunyoung1819 yunyoung1819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@seonghun-dev
Copy link
Collaborator Author

There are many changes, so we will meet and deal with them at once

@seonghun-dev seonghun-dev deleted the config/module-name-change branch September 22, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants