✨ feat(api): add user unblock api #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yunyoung1819
commented
Jul 23, 2023
yunyoung1819
commented
- Resolve: Add User Unblock API #205
seonghun-dev
requested changes
Jul 23, 2023
| @@ -21,9 +22,19 @@ public class UserBlockController { | |||
| @PostMapping("/users/block") | |||
| public ResponseEntity<BlockUserResponseDto> blockUser( | |||
| @ReqUser User user, | |||
| @RequestParam(value = "blockUserID") Long blockUserID | |||
| @RequestParam(value = "blockUserId") Long blockUserId | |||
There was a problem hiding this comment.
변경하면 이전버전 IOS에서 호환이 안되어서 우선은 유지해야 될 것 같습니다. 변경하려고 하면 버저닝 해서 기존꺼 유지하면서 다른 API로 추가하고 충분히 업데이트 되면 기존 버전을 없애는 방식으로 처리해야될 것 같습니다
There was a problem hiding this comment.
넵 따로 기능이 변경된 것은 아니여서 버저닝하기보단 파라미터를 기존 이름으로 복원하였습니다.
기존 api 수정 시 버저닝도 계속 고려해야겠군요.
수정 완료했습니다. 감사합니다. Good!
seonghun-dev
pushed a commit
that referenced
this pull request
Jul 31, 2023
* ✨ feat: add user unblock api * ♻️ refactor: UserBlockService blockUser Parameter name rollback * ♻️ refactor: UserBlockService blockUser Parameter name rollback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.