fix: 회고 수정 기능 버그 (#252)

* test: test 코드 오류 해결 * fix: deadline null 인 경우 핸들링 * chore: prod로 수정
depromeet · Oct 30, 2024 · 7cb3f6c · 7cb3f6c
1 parent 1d760e6
commit 7cb3f6c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/layer-api/src/main/resources/application-dev.yml b/layer-api/src/main/resources/application-dev.yml
@@ -8,7 +8,7 @@ spring:
     driver-class-name: com.mysql.cj.jdbc.Driver
   jpa:
     hibernate:
-      ddl-auto: update
+      ddl-auto: validate
     properties:
       hibernate:
         format_sql: true
@@ -49,7 +49,7 @@ google:
   sheet:
     id: ${GOOGLE_SHEET_ID}
     token_path: ${PROD_GOOGLE_TOKEN_PATH}
-    credential_path: ${PROD_GOOGLE_CREDENTIAL_PATH}
+    credential_path: ${PROD_GOOGLE_TOKEN_PATH}
 
 apple:
   login:

diff --git a/layer-domain/src/main/java/org/layer/domain/retrospect/entity/Retrospect.java b/layer-domain/src/main/java/org/layer/domain/retrospect/entity/Retrospect.java
@@ -78,7 +78,7 @@ public void validateRetrospectStatusDone() {
 
 	public void updateRetrospect(String title, String introduction, LocalDateTime deadline, Time time) {
 
-		if (deadline.isBefore(time.now())) {
+		if (deadline != null && deadline.isBefore(time.now())) {
 			throw new RetrospectException(INVALID_DEADLINE);
 		}
 

diff --git a/layer-domain/src/test/java/layer/domain/retrospect/entity/RetrospectTest.java b/layer-domain/src/test/java/layer/domain/retrospect/entity/RetrospectTest.java
@@ -4,6 +4,7 @@
 
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.Test;
+import org.layer.domain.retrospect.entity.AnalysisStatus;
 import org.layer.domain.retrospect.entity.Retrospect;
 import org.layer.domain.retrospect.entity.RetrospectStatus;
 
@@ -12,7 +13,7 @@ public class RetrospectTest {
 	@Test
 	void 진행중인_회고는_진행여부로직에서_예외를_발생시키지_않는다() {
 		// given
-		Retrospect retrospect = new Retrospect(1L, "회고제목입니다", "회고소개입니다", RetrospectStatus.PROCEEDING,
+		Retrospect retrospect = new Retrospect(1L, "회고제목입니다", "회고소개입니다", RetrospectStatus.PROCEEDING, AnalysisStatus.PROCEEDING,
 			LocalDateTime.of(2024, 8, 4, 3, 5));
 
 		// when

diff --git a/layer-domain/src/test/java/layer/domain/retrospect/repository/RetrospectRepositoryTest.java b/layer-domain/src/test/java/layer/domain/retrospect/repository/RetrospectRepositoryTest.java
@@ -5,6 +5,7 @@
 import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
+import org.layer.domain.retrospect.entity.AnalysisStatus;
 import org.layer.domain.retrospect.entity.Retrospect;
 import org.layer.domain.retrospect.entity.RetrospectStatus;
 import org.layer.domain.retrospect.repository.RetrospectRepository;
@@ -21,7 +22,7 @@ public class RetrospectRepositoryTest {
 	@Test
 	void 멀티모듈_레포지토리_테스트() {
 		// given
-		Retrospect retrospect = new Retrospect(1L, "회고제목입니다", "회고소개입니다", RetrospectStatus.PROCEEDING,
+		Retrospect retrospect = new Retrospect(1L, "회고제목입니다", "회고소개입니다", RetrospectStatus.PROCEEDING, AnalysisStatus.PROCEEDING,
 			LocalDateTime.of(2024, 8, 4, 3, 5));
 
 		// when