[Refactor/recommendation 223] 탑승/하차 코드 리팩토링 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation-223 # Conflicts: # src/main/java/kr/co/antoon/webtoon/facade/WebtoonStatusFacade.java # src/main/java/kr/co/antoon/webtoon/presentation/WebtoonController.java
yunyoung1819
requested review from
devsungmin,
twoosky,
DongGeon0908 and
xx10222
devsungmin
approved these changes
Sep 6, 2022
| webtoonStatusCount, | ||
| status | ||
| ); | ||
| return antCoinService.joinWebtoon(userId, webtoonId, response, status); |
There was a problem hiding this comment.
Suggested change
| return antCoinService.joinWebtoon(userId, webtoonId, response, status); | |
| return antCoinService.joinWebtoon(joinWebtoonDto); |
이런식으로 dto 객체를 만들어서 하는 건 어떠신가요??
There was a problem hiding this comment.
넵! 객채로 만들어서 전달하는 것이 더 깔끔하고 가독성도 좋을 것 같아용! 리뷰 감사합니다. 수정해서 올릴게여
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
📑 작업 사항
✒️ 코드 리뷰 요청 사항
✔️ 코드 리뷰 반영 사항